include public.file-url data for pasteboard objects #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,6 +53,8 @@ - (void)writeToPasteboard:(NSPasteboard *)pasteboard data:(id)pbData forType:(NS | |||
| [pasteboard addTypes:[NSArray arrayWithObjects:NSURLPboardType, NSStringPboardType, nil] owner:nil]; | |||
| [pasteboard setString:([pbData hasPrefix:@"mailto:"]) ?[pbData substringFromIndex:7] :pbData forType:NSStringPboardType]; | |||
| [pasteboard setString:[pbData URLDecoding] forType:NSURLPboardType]; | |||
| } else if ([type isEqualToString:@"public.file-url"]) { | |||
| [pasteboard setString:pbData[0] forType:type]; | |||
There was a problem hiding this comment.
Might be worth checking [pbData isKindOfClass:[NSArray class]] just incase something goes askew? Don't really see how.
|
Yep you're right, this is kinda hacky, but all of this pasteboard stuff is already hacky. Other than my comment, go ahead and merge. |
before assuming we can get the first element
|
Added the array check. |
skurfer
added a commit
that referenced
this pull request
Apr 17, 2014
include public.file-url data for pasteboard objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here’s an attempt at fixing #1805. I tried to do it with as few changes as possible. Note that no changes to the plug-in were required.
Probably not perfect, but this code should all go away soon, right?